Skip to content

Conversation

@sameerag
Copy link
Member

@sameerag sameerag commented Dec 8, 2025

Address CVE alerts for msal-v5

@sameerag sameerag marked this pull request as ready for review December 9, 2025 00:16
@sameerag sameerag requested review from a team as code owners December 9, 2025 00:16
Copilot AI review requested due to automatic review settings December 9, 2025 00:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to address CVEs by updating multiple dependencies across sample applications and libraries. The updates include axios, nodemon, Playwright, Electron, Angular packages, and other dependencies to newer versions that presumably fix security vulnerabilities.

Key changes:

  • Security dependency updates across sample applications (axios, nodemon, Playwright, Electron, Angular packages)
  • Updates to @azure/identity, semver, and puppeteer packages
  • Formatting changes to package.json files (indentation standardization)

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
samples/msal-node-samples/silent-flow/package.json Updated axios to ^1.12.0
samples/msal-node-samples/on-behalf-of-distributed-cache/package.json Updated axios to ^1.12.0, nodemon to ^3.1.11, formatting changes
samples/msal-node-samples/custom-INetworkModule-and-network-tracing/package.json Updated axios to 1.12.0
samples/msal-node-samples/client-credentials-distributed-cache/package.json Updated axios to ^1.12.0, nodemon to ^3.1.11, formatting changes
samples/msal-node-samples/b2c-user-flows/package.json Updated axios to ^1.12.0
samples/msal-node-samples/auth-code-key-vault/package.json Updated @azure/identity to ^4.5.0, formatting changes
samples/msal-node-samples/auth-code-distributed-cache/package.json Updated axios to ^1.12.0, nodemon to ^3.1.11, formatting changes
samples/msal-node-samples/auth-code-cli-app/package.json Updated axios to ^1.12.0
samples/msal-node-samples/ElectronSystemBrowserTestApp/package.json Updated @playwright/test to ^1.56.0, electron to ^36.9.5, axios to ^1.12.0
samples/msal-browser-samples/TestingSample/package.json Updated @playwright/test to ^1.56.0, formatting changes
samples/msal-browser-samples/HybridSample/package.json Updated nodemon to ^3.1.11
samples/msal-browser-samples/ExpressSample/package.json Updated nodemon to ^3.1.11
samples/msal-browser-samples/COOP/sts/package.json Updated @playwright/test to ^1.56.0, formatting changes
samples/msal-browser-samples/COOP/package.json Updated @playwright/test to ^1.56.0, electron to ^36.9.5, formatting changes
samples/msal-angular-samples/angular-standalone-sample/package.json Updated Angular packages to 20.3.x versions
samples/msal-angular-samples/angular-modules-sample/package.json Updated Angular packages to 20.3.x versions
samples/msal-angular-samples/angular-b2c-sample/package.json Updated Angular packages to 20.3.x and 20.2.x versions, fixed karma formatting
samples/e2eTestUtils/package.json Updated axios to ^1.12.0, playwright-core to ^1.56.0, puppeteer to ^24.29.0
package.json Updated @angular/compiler to ^19.2.17, semver to ^7.7.3
lib/msal-angular/package.json Updated Angular dev dependencies to 19.2.15/16 versions
extensions/samples/electron-webpack/package.json Updated electron to ^36.9.5, formatting changes
change/@azure-msal-angular-e230b80b-b14b-4696-9d63-ad0fcbb416be.json Added beachball changefile for the CVE fixes

Copy link
Contributor

Copilot AI commented Dec 9, 2025

@sameerag I've opened a new pull request, #8192, to work on those changes. Once the pull request is ready, I'll request review from you.

sameerag and others added 4 commits December 8, 2025 21:19
New branch naming isn't caught by the existing beachball branch filter,
causing beachball check not to be skipped in post-release PRs.
This PR contains the changelogs and version bumps for the MSAL.js 3P
releases.

---------

Co-authored-by: MSAL.js Release Automation <[email protected]>
Co-authored-by: Konstantin <[email protected]>
…8191)

Use cross-env for environment variable management in build scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants