Merged
Conversation
Closed
5 tasks
Pull Request Test Coverage Report for Build 19641825593Details
💛 - Coveralls |
JosePizarro3
approved these changes
Nov 21, 2025
Member
JosePizarro3
left a comment
JosePizarro3
left a comment
There was a problem hiding this comment.
Just some minor code style comments
carlosmada22
force-pushed
the
225-solve-checker-bugs
branch
from
dd0cdf2 to
bb9bfed
Compare
CagtayFabry
pushed a commit
to CagtayFabry/bam-masterdata
that referenced
this pull request
Dec 17, 2025
* Solved bugs * Solved bugs * Fix problem * Added confirmation message where there are no errors in checker * Solved review * Solved review * Solved review * Solved review * Solved review * Solved review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the bugs presented here were solved. There is a minor bug affecting how the vocabularies are read ([terms] key problem), that should be solved in another issue. Can you do this meanwhile I am not here @JosePizarro3 ?