chore: update comparisons.scad#1543
Merged
revarbat merged 1 commit intoBelfrySCAD:masterfrom Jan 22, 2025
eltociear:patch-1
Merged
chore: update comparisons.scad#1543revarbat merged 1 commit intoBelfrySCAD:masterfrom eltociear:patch-1
revarbat merged 1 commit intoBelfrySCAD:masterfrom
eltociear:patch-1
Conversation
occurences -> occurrences
Contributor
|
If you're going to submit a fix for a typo, you might want to go through that file again to be sure you didn't miss others. For example, I found a couple cases of "approximately" misspelled with one "p". Throughout other files, there's mixed usage of "toward" vs "towards" (the first is correct, but the latter seems more frequent here). There's also a lot of unnecessary future tense ("will" versus active-voice present-tense). Generally if I'm contributing code changes, I try to clean up the documentation at the same time, but it might be worthwhile to go through everything and make one big typo-correction PR, because the Wiki pages have to be rebuilt when the documentation in the comments changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
occurences -> occurrences