Skip to content

chore: update comparisons.scad#1543

Merged
revarbat merged 1 commit intoBelfrySCAD:masterfrom
eltociear:patch-1
Jan 22, 2025
Merged

chore: update comparisons.scad#1543
revarbat merged 1 commit intoBelfrySCAD:masterfrom
eltociear:patch-1

Conversation

@eltociear
Copy link
Contributor

occurences -> occurrences

occurences -> occurrences
@amatulic
Copy link
Contributor

amatulic commented Jan 16, 2025

If you're going to submit a fix for a typo, you might want to go through that file again to be sure you didn't miss others. For example, I found a couple cases of "approximately" misspelled with one "p".

Throughout other files, there's mixed usage of "toward" vs "towards" (the first is correct, but the latter seems more frequent here). There's also a lot of unnecessary future tense ("will" versus active-voice present-tense). Generally if I'm contributing code changes, I try to clean up the documentation at the same time, but it might be worthwhile to go through everything and make one big typo-correction PR, because the Wiki pages have to be rebuilt when the documentation in the comments changes.

@revarbat revarbat merged commit a2f69be into BelfrySCAD:master Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants