Skip to content

Running on gaea #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025
Merged

Running on gaea #1013

merged 5 commits into from
May 28, 2025

Conversation

rgrumbine
Copy link
Contributor

@rgrumbine rgrumbine commented Mar 31, 2025

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Macros and env to run on gaea
  • Developer(s):
    Robert Grumbine
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    executes quick_suite
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No

@DeniseWorthen
Copy link
Contributor

Is there a reason not to add C6 in addition to C5?

@@ -0,0 +1,57 @@
#==============================================================================
# Makefile macros for NOAA hera, intel compiler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hera->gaeaC5

@@ -7,20 +7,27 @@ endif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env.gaea should probably be env.gaeac5 since this I presume gaeac6 would be different.

@apcraig
Copy link
Contributor

apcraig commented Apr 9, 2025

I'm happy to merge this when ready. @rgrumbine @DeniseWorthen, just let me know when you're happy and when it's ready.

@DeniseWorthen
Copy link
Contributor

@rgrumbine Gaea C5 and C6 are different machines. If the intent is to enable on Gaea, it needs to be clear which gaea.

@rgrumbine
Copy link
Contributor Author

Agreed Denise. I'll make the update(s)

@apcraig apcraig added the Porting label Apr 9, 2025
@rgrumbine
Copy link
Contributor Author

I've made the changes and passed the quick_start suite.

@DeniseWorthen
Copy link
Contributor

Are files Macros.gaea_intel and env.gaea_intel still required?

setenv ICE_MACHINE_ENVINFO "ifort 18.0.5 20180823, cray-mpich, cray-netcdf"
setenv ICE_MACHINE_MAKE gmake
setenv ICE_MACHINE_WKDIR $HOME/scratch/CICE_RUNS
setenv ICE_MACHINE_INPUTDATA /ncrc/home1/Robert.Grumbine/rgdev/CICE_INPUTDATA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This input would not be available to anyone else on Gaea. I'd suggest moving it to a world-shared space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macros.gaea_intel and env.gaea_intel aren't required, but do work on both c5 and c6.

The path is actually a link to a world-shared disk. Specifying it this way, though, gives some parallelism between different platforms. For gaea, hera, and wcoss2, the path is $BOBHOME/rgdev/CICE_INPUTDATA

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but Gaea provides "world-shared" project space for this purpose, eg /gpfs/f5/epic/world-shared/...

@eclare108213
Copy link
Contributor

@rgrumbine @DeniseWorthen we are working toward a numbered release in the next few weeks, so please finish this up if you'd like to have it included. I generally think it's better to use generic, world-readable pathnames rather than those with specific usernames, for maintenance reasons.

@rgrumbine
Copy link
Contributor Author

I agree about avoiding over-specific file paths. In this case, it is as for using Tony Craig's path on hera and other systems -- to have a shared location for the CICE input data files. At least when I started, Tony wasn't on gaea.

@DeniseWorthen I think I addressed your concerns about c5 vs. c6

@DeniseWorthen
Copy link
Contributor

@rgrumbine OK, thanks. I think the "generic" gaea files (ie, w/o the c5/c6 attribute) should be removed, but I leave that to the preferences of the upstream managers to request.

I would also only note that C5 is no longer a Tier 1 platform for UWM, only C6 is now Tier 1.

I'll approve in the interests of moving the PR along though.

@rgrumbine
Copy link
Contributor Author

thanks @DeniseWorthen

@apcraig apcraig merged commit 636856f into CICE-Consortium:main May 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants