feat: score attestations for block by profitability #8016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## unstable #8016 +/- ##
=========================================
Coverage 55.68% 55.68%
=========================================
Files 835 835
Lines 59476 59491 +15
Branches 4585 4586 +1
=========================================
+ Hits 33119 33130 +11
- Misses 26290 26294 +4
Partials 67 67 🚀 New features to boost your workflow:
|
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
reviewed
Jun 27, 2025
There was a problem hiding this comment.
while I see how straightforward it is to bring processAttestation reward computation to this flow, we need to also consider how this affects blockprint because we change our algorithm and how unique we are compared to other client (which the old algorithm is)
with our total consolidations are < 8 most of the time, this will not bring better block profit compared to our current sort algorithm
I'd keep the old sorting algorithm and put this new sorting algorithm as a comment or refer to it somewhere so that it give us more insights when we have to revisit this later, unless metrics show we have better profit with this
|
As noted by Michael, keeping the current sorting / scoring is good for blockprint as it’s slightly different from other clients and should help differentiate Lodestar. I also tend towards just closing this for now and revisit in the future / in different network conditions as it could make a difference during non-finality when there are a lot of different votes (less consolidation) + missed slots which require us to fill up the block most of the time. |
|
created an issue #8019 to keep track of this |
|
based on data from running this on it makes sense to re-test this branch in a non-finality network or once we have implemented #8028 |
no reason, I think we can merge this. I'm not sure when can I continue with SingleAttestation inclusion for block production anyway. |
twoeths
approved these changes
Aug 27, 2025
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the scoring mechanism for attestations to maximize block profitability. The new logic correctly uses participation flags (timely source, target, and head) and their associated weights to score attestations, which is a more accurate model of the actual proposer rewards compared to the previous heuristic. The implementation looks solid. I've added one suggestion to improve the readability of the weight calculation logic.
|
🎉 This PR is included in v1.34.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates scoring / sorting of consolidated attestations during block packing to follow
processAttestationreward computation to maximize profitability of block.lodestar/packages/state-transition/src/block/processAttestationsAltair.ts
Line 33 in 2fdd3fa
Closes #8019