Skip to content

Conversation

@edna-harriet
Copy link

@edna-harriet edna-harriet commented Oct 27, 2025

Closes issue #8171

Motivation
This PR replaces documentation and code references that previously pointed to the dev, main, master branches while also updating existing SHA commits with the release tags. However, references with SHA commits that would re-direct to broken page(Error 404) when replaced with tags, have not been changed.Those references still have their SHA commits.

Description
-Updated only .ts files containing github.com/ethereum/consensus-specs/blob/dev or main or master links.
-Also verified that no auto-generated file such as .js and .d.ts were modified.

Steps to test or reproduce
$ cd lodestar
$ git checkout issue-#8171
$ grep -Rnl "https://github.com/ethereum/consensus-specs/blob/[0-9a-f]\{7,40\}" --include='.ts' --exclude='.d.ts' --exclude='*.js' .

Conclusion
I invite review and I am ready to make request changes.

@edna-harriet edna-harriet requested a review from a team as a code owner October 27, 2025 09:17
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @edna-harriet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically updates all external references within the codebase, primarily focusing on links to Ethereum consensus specifications. The goal is to enhance the reliability and precision of our documentation and code comments by ensuring that all referenced specifications are linked via stable, verified SHA commits rather than potentially changing branch names. This prevents broken links and ensures that the codebase always refers to the exact version of the specification it was built against.

Highlights

  • Reference Updates: Replaced outdated documentation and code references that previously pointed to volatile branches (e.g., 'dev', 'main', 'master') with immutable SHA commits for improved stability and accuracy.
  • SHA Commit Verification: Updated existing SHA commit references to their most current verified versions, ensuring all links point to the latest stable specifications.
  • File Scope: Changes were specifically applied to '.ts' files containing 'github.com/ethereum/consensus-specs/blob/dev' links, while carefully avoiding modifications to auto-generated files like '.js' and '.d.ts'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on updating documentation and code references to point to the most current SHA commits, replacing outdated branch references. The changes primarily involve updating .ts files and adding 'Reference' prefixes to comments that link to external resources. I have identified some areas where the addition of 'Reference' seems unnecessary and suggest removing them to maintain clarity and conciseness.

@gemini-code-assist
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@matthewkeil
Copy link
Member

Glad to see you getting this worked through. Per our discussion on discord DM we would prefer to use spec release version tags. I see that @nflaig has mentioned that above as well. Please use this format

https://github.com/ethereum/consensus-specs/blob/v1.5.0/specs/altair/beacon-chain.md#has_flag

Also please address the Gemini comments and remove the added lines. All that is necessary is the link itself.

@edna-harriet
Copy link
Author

edna-harriet commented Oct 28, 2025

@matthewkeil @nflaig , all your feedbacks are taken in. Am working on it. there are afew references that opens with SHA commit but when i change that to release tags(from the different available versions), the page breaks-Error 404. What do you advise I do in such case?

@nflaig
Copy link
Member

nflaig commented Oct 28, 2025

there are afew references that opens with SHA commit but when i change that to release tags(from the different available versions), the page breaks-Error 404. What do you advise I do in such case?

Links that are already using a commit sha are already permalinks, there is no need to update them

@edna-harriet
Copy link
Author

@nflaig @matthewkeil , I am ready for another review. I have implemented all AI and your requested changes.Thank you.

@edna-harriet
Copy link
Author

there are afew references that opens with SHA commit but when i change that to release tags(from the different available versions), the page breaks-Error 404. What do you advise I do in such case?

Links that are already using a commit sha are already permalinks, there is no need to update them

Noted

@nflaig
Copy link
Member

nflaig commented Oct 28, 2025

@nflaig @matthewkeil , I am ready for another review. I have implemented all AI and your requested changes.Thank you.

it doesn't seem like it, there are still extra modifications and links that are already permalinks shouldn't be updated

@edna-harriet
Copy link
Author

@nflaig @matthewkeil , I worked on this and awaiting your review.

@matthewkeil
Copy link
Member

@nflaig @matthewkeil , I worked on this and awaiting your review.

I think you still have some review to do. Please go through the files view of this PR to self audit where your work stands.
https://github.com/ChainSafe/lodestar/pull/8574/files

There are still a bunch of added empty lines, added words before the updated links (like * Reference : on_payload) and deleted existing comments. The bar for inclusion into the codebase is high and needs a very detailed look. Please make sure everything is 100% before marking this as ready for review. Once you go through each of the comments above and resolve each, please click the resolve button on the comment.

@matthewkeil matthewkeil changed the title fix: this PR fixes Issue #8171 fix: change all doc links to permalinks Oct 30, 2025
@edna-harriet
Copy link
Author

@nflaig @matthewkeil , I worked on this and awaiting your review.

I think you still have some review to do. Please go through the files view of this PR to self audit where your work stands. https://github.com/ChainSafe/lodestar/pull/8574/files

There are still a bunch of added empty lines, added words before the updated links (like * Reference : on_payload) and deleted existing comments. The bar for inclusion into the codebase is high and needs a very detailed look. Please make sure everything is 100% before marking this as ready for review. Once you go through each of the comments above and resolve each, please click the resolve button on the comment.

@matthewkeil , i feel abit lost on this task. I know there are reference comments that I added that should be removed eg the one you have cited above (Reference : on_payload). how about these ones where i replaced branch name with tag? what specifically am I supposed to correct about it? Remove the //Mainnet config OR leave the link with the dev branch as it was initially? Kindly shed some clarity on it?

// Mainnet config
// https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml
// https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/configs/mainnet.yaml

@matthewkeil
Copy link
Member

matthewkeil commented Oct 30, 2025

@nflaig @matthewkeil , I worked on this and awaiting your review.

I think you still have some review to do. Please go through the files view of this PR to self audit where your work stands. https://github.com/ChainSafe/lodestar/pull/8574/files
There are still a bunch of added empty lines, added words before the updated links (like * Reference : on_payload) and deleted existing comments. The bar for inclusion into the codebase is high and needs a very detailed look. Please make sure everything is 100% before marking this as ready for review. Once you go through each of the comments above and resolve each, please click the resolve button on the comment.

@matthewkeil , i feel abit lost on this task. I know there are reference comments that I added that should be removed eg the one you have cited above (Reference : on_payload). how about these ones where i replaced branch name with tag? what specifically am I supposed to correct about it? Remove the //Mainnet config OR leave the link with the dev branch as it was initially? Kindly shed some clarity on it?

// Mainnet config // https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/configs/mainnet.yaml

I added a couple notes above. I hope that helps. Please also make sure to click "resolve" for the gemini created issues if they are fixed.

@edna-harriet
Copy link
Author

edna-harriet commented Oct 31, 2025 via email

@nflaig
Copy link
Member

nflaig commented Oct 31, 2025

@edna-harriet all you have to do for this issue is search the code for consensus-specs/blob/dev/specs and replace those with a tag instead of referencing dev branch

any other modifications like extra new lines, reformatting need to be avoided

@matthewkeil matthewkeil marked this pull request as draft November 3, 2025 04:51
@edna-harriet edna-harriet marked this pull request as ready for review November 5, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants