fix: change all doc links to permalinks #8574
+5,093
−44
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -690,7 +690,9 @@ export class Network implements INetwork { | |
|
|
||
| try { | ||
| // messages SHOULD be broadcast after SYNC_MESSAGE_DUE_BPS of slot has transpired | ||
|
|
||
|
|
||
| // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/specs/altair/light-client/p2p-interface.md#sync-committee | ||
| await this.waitForSyncMessageCutoff(finalityUpdate.signatureSlot); | ||
| await this.publishLightClientFinalityUpdate(finalityUpdate); | ||
| } catch (e) { | ||
|
|
@@ -707,7 +709,7 @@ export class Network implements INetwork { | |
|
|
||
| try { | ||
| // messages SHOULD be broadcast after SYNC_MESSAGE_DUE_BPS of slot has transpired | ||
| // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/specs/altair/light-client/p2p-interface.md#sync-committee | ||
| await this.waitForSyncMessageCutoff(optimisticUpdate.signatureSlot); | ||
| await this.publishLightClientOptimisticUpdate(optimisticUpdate); | ||
| } catch (e) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -57,7 +57,8 @@ export type ReqRespBeaconNodeOpts = ReqRespOpts & {disableLightClientServer?: bo | |||||
| * Implementation of Ethereum Consensus p2p Req/Resp domain. | ||||||
| * For the spec that this code is based on, see: | ||||||
| * https://github.com/ethereum/consensus-specs/blob/v1.1.10/specs/phase0/p2p-interface.md#the-reqresp-domain | ||||||
| * Reference : the-reqresp-domain | ||||||
|
||||||
| * Reference : the-reqresp-domain | |
| * https://github.com/ethereum/consensus-specs/blob/03c4ea240fccfa78469aa039a4a7177beca54074/specs/altair/light-client/p2p-interface.md#the-reqresp-domain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,7 +47,7 @@ export async function* onBlobSidecarsByRange( | |
| // Note: Here the forkChoice head may change due to a re-org, so the headChain reflects the canonical chain | ||
| // at the time of the start of the request. Spec is clear the chain of blobs must be consistent, but on | ||
| // re-org there's no need to abort the request | ||
| // Spec: https://github.com/ethereum/consensus-specs/blob/v1.2.0/specs/eip4844/p2p-interface.md#blobssidecarsbyrange-v1 | ||
|
|
||
| const blobSideCarsBytesWrapped = await unfinalized.getBinary(fromHex(block.blockRoot)); | ||
| if (!blobSideCarsBytesWrapped) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,7 @@ export async function* onBlobSidecarsByRoot( | |
|
|
||
| // NOTE: Only support non-finalized blocks. | ||
| // SPEC: Clients MUST support requesting blocks and sidecars since the latest finalized epoch. | ||
| // https://github.com/ethereum/consensus-specs/blob/v1.2.0/specs/eip4844/p2p-interface.md#beaconblockandblobssidecarbyroot-v1 | ||
| if (!block || block.slot <= finalizedSlot) { | ||
| continue; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,7 +79,7 @@ export async function* onDataColumnSidecarsByRange( | |
| // Note: Here the forkChoice head may change due to a re-org, so the headChain reflects the canonical chain | ||
| // at the time of the start of the request. Spec is clear the chain of columns must be consistent, but on | ||
| // re-org there's no need to abort the request | ||
| // Spec: https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/specs/fulu/p2p-interface.md#L425-L429 | ||
| const dataColumnSidecars = await unfinalized.getManyBinary(fromHex(block.blockRoot), availableColumns); | ||
|
|
||
| const unavailableColumnIndices: ColumnIndex[] = []; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -128,7 +128,8 @@ export class BackfillSync extends (EventEmitter as {new (): BackfillSyncEmitter} | |||||
| private wsValidated = false; | ||||||
|
|
||||||
| /** | ||||||
| * Reference : | ||||||
|
||||||
| * Reference : | |
| * From https://github.com/ethereum/consensus-specs/blob/46306c4f8addef64defc2a52d85f46992ba2421b/specs/phase0/weak-subjectivity.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,7 +59,7 @@ export const BATCH_BUFFER_SIZE = Math.ceil(10 / EPOCHS_PER_BATCH); | |
|
|
||
| /** | ||
| * Maximum number of concurrent requests to perform with a SyncChain. | ||
| * This is according to the spec https://github.com/ethereum/consensus-specs/blob/46306c4f8addef64defc2a52d85f46992ba2421b/specs/phase0/p2p-interface.md | ||
| */ | ||
| export const MAX_CONCURRENT_REQUESTS = 2; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -25,7 +25,8 @@ export const testFnByType: Record<string, "skip" | ((data: any) => any)> = { | |||||
| }; | ||||||
|
|
||||||
| /** | ||||||
| * Reference : aggregate_verify | ||||||
|
||||||
| * Reference : aggregate_verify | |
| * https://github.com/ethereum/bls12-381-tests/blob/7a1e2f64adf524d7c53c33c7bfbed6afcc73f664/formats/aggregate_verify.md |
Outdated
There was a problem hiding this comment.
The Reference : batch_verify prefix seems unnecessary. The subsequent line provides the direct link to the specification, which serves as the reference. Removing the Reference prefix would improve readability.
Suggested change
| * Reference : batch_verify | |
| * https://github.com/ethereum/bls12-381-tests/blob/2e357bf380a3eb72883f529d0e303ae03251767c/formats/batch_verify.md |
Outdated
There was a problem hiding this comment.
The Reference - sign.md prefix seems unnecessary. The subsequent line provides the direct link to the specification, which serves as the reference. Removing the Reference prefix would improve readability.
Suggested change
| * Reference - sign.md | |
| * https://github.com/ethereum/bls12-381-tests/blob/c01854d47b936b65404e5f08181f05db48792679/formats/sign.md |
Outdated
There was a problem hiding this comment.
The Reference : deserialization_G1 prefix seems unnecessary. The subsequent line provides the direct link to the specification, which serves as the reference. Removing the Reference prefix would improve readability.
Suggested change
| * Reference : deserialization_G1 | |
| * https://github.com/ethereum/bls12-381-tests/blob/f61f5f01e41c0e422d812d1254f06e89c2531c5b/formats/deserialization_G1.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ const epochTransitionFns: Record<string, EpochTransitionFn> = { | |
| }; | ||
|
|
||
| /** | ||
| * https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/tests/formats/epoch_processing/README.md | ||
| */ | ||
| type EpochTransitionCacheingTestCase = { | ||
| meta?: {bls_setting?: bigint}; | ||
|
|
@@ -86,7 +86,7 @@ const epochProcessing = | |
|
|
||
| if (testcase.post === undefined) { | ||
| // If post.ssz_snappy is not value, the sub-transition processing is aborted | ||
| // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/tests/formats/epoch_processing/README.md#postssz_snappy | ||
| expect(() => epochTransitionFn(state, epochTransitionCache)).toThrow(); | ||
| } else { | ||
| epochTransitionFn(state, epochTransitionCache); | ||
|
|
@@ -121,7 +121,7 @@ specTestIterator(path.join(ethereumConsensusSpecsTests.outputDir, "tests", ACTIV | |
| fn: epochProcessing([ | ||
| // TODO: invalid_large_withdrawable_epoch asserts an overflow on a u64 for its exit epoch. | ||
| // Currently unable to reproduce in Lodestar, skipping for now | ||
| // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/tests/core/pyspec/eth2spec/test/phase0/epoch_processing/test_process_registry_updates.py#L349 | ||
| "invalid_large_withdrawable_epoch", | ||
| ]), | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,7 +70,8 @@ export function generateBlocksSZZTypeMapping(fork: ForkName, n: number): BlocksS | |
| * ``` | ||
| * {blocks_count: 16} | ||
| * ``` | ||
| * | ||
| * https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/tests/formats/finality/README.md | ||
| */ | ||
| type FinalityTestCase = { | ||
| [k: string]: altair.SignedBeaconBlock | unknown | null | undefined; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ import {RootHex, ssz} from "@lodestar/types"; | |
| import {toHex} from "@lodestar/utils"; | ||
| import {TestRunnerFn} from "../../utils/types.js"; | ||
|
|
||
| // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/tests/formats/light_client/single_merkle_proof.md | ||
| type SingleMerkleProofTestCase = { | ||
| meta?: any; | ||
| object: TreeViewDU<any>; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ import {fromHex, toHex} from "@lodestar/utils"; | |
| import {testLogger} from "../../../utils/logger.js"; | ||
| import {TestRunnerFn} from "../../utils/types.js"; | ||
|
|
||
| // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/tests/formats/light_client/single_merkle_proof.md | ||
| type SyncTestCase = { | ||
| meta: { | ||
| genesis_validators_root: RootHex; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ import {InputType} from "@lodestar/spec-test-util"; | |
| import {LightClientUpdate, altair, ssz, sszTypesFor} from "@lodestar/types"; | ||
| import {TestRunnerFn} from "../../utils/types.js"; | ||
|
|
||
| // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/tests/formats/light_client/update_ranking.md | ||
| type UpdateRankingTestCase = { | ||
| meta: { | ||
| updates_count: bigint; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,9 @@ import {RunnerType} from "../utils/types.js"; | |
| // | serialized.ssz_snappy | ||
| // | value.yaml | ||
| // | ||
| // | ||
| // | ||
| // Docs: https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/tests/formats/ssz_static/core.md | ||
|
|
||
| type Types = Record<string, Type<any>>; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,8 +55,6 @@ export function isVotingKeystore(filename: string): boolean { | |
| // However, that's too restrictive. Guide left here as a reference | ||
| // | ||
| // The format exported by the `staking-deposit-cli` library. | ||
edna-harriet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // https://github.com/ethereum/staking-deposit-cli/blob/7cebff15eac299b3b1b090c896dd3410c8463450/eth2deposit/credentials.py#L58-L62 | ||
| // | ||
| // Since we include the key derivation path of `m/12381/3600/x/0/0` this should only ever match | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,8 @@ import {PresetName} from "@lodestar/params"; | |
| import {fromHex as b} from "@lodestar/utils"; | ||
| import {ChainConfig} from "../types.js"; | ||
|
|
||
|
|
||
| // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/configs/mainnet.yaml | ||
|
|
||
| export const chainConfig: ChainConfig = { | ||
| // Extends the mainnet preset | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,8 @@ import {PresetName} from "@lodestar/params"; | |
| import {fromHex as b} from "@lodestar/utils"; | ||
| import {ChainConfig} from "../types.js"; | ||
|
|
||
|
|
||
| // https://github.com/ethereum/consensus-specs/blob/v1.6.0-alpha.6/configs/minimal.yaml | ||
|
|
||
| export const chainConfig: ChainConfig = { | ||
| // Extends the minimal preset | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ import {ChainConfig} from "../types.js"; | |
| import {gnosisChainConfig as gnosis} from "./gnosis.js"; | ||
|
|
||
| // Chiado beacon chain config: | ||
| // https://github.com/gnosischain/configs/blob/3f44fafa888439f56fc60d2f6173bfe63f31c962/chiado/config.yaml | ||
|
|
||
| export const chiadoChainConfig: ChainConfig = { | ||
| ...gnosis, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,8 @@ import {chainConfig as mainnet} from "../configs/mainnet.js"; | |
| import {ChainConfig} from "../types.js"; | ||
|
|
||
| // Ephemery dynamic beacon chain config: | ||
|
|
||
| // https://github.com/ephemery-testnet/ephemery-genesis/blob/dbc3377143c6fc1a688d4a9c648f89d8812ec7aa/cl-config.yaml | ||
|
|
||
| // Ephemery specification: | ||
| // https://eips.ethereum.org/EIPS/eip-6916 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,8 @@ import {chainConfig as mainnet} from "../configs/mainnet.js"; | |
| import {ChainConfig} from "../types.js"; | ||
|
|
||
| // Gnosis beacon chain config: | ||
|
|
||
| // https://github.com/gnosischain/configs/blob/d447a94bbe1bafbef4fe5a2fbb2e5469e7b494bb/mainnet/config.yaml | ||
|
|
||
| export const gnosisChainConfig: ChainConfig = { | ||
| ...mainnet, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.