fix: delayed broadcasting of Voluntary exits

[pheobeayo]

Motivation

Delayed broadcasting of voluntary exits

Description

This PR handles

Better UX - accepts early submissions
More forgiving for DVT/multi-node setups
post-Electra pending withdrawal checks gracefully

Closes #7431

Steps to test or reproduce

I used Claude to understand some of the concepts needed to fix the issue

[gemini-code-assist]

Summary of Changes

Hello @pheobeayo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to how voluntary exits are handled by implementing delayed broadcasting. By deferring the network publication of voluntary exits to an operation pool and refining the validation process to separate permanent and transient checks, the system offers a more robust and user-friendly experience. This change specifically benefits DVT and multi-node setups by allowing for early submissions and more graceful handling of pending withdrawals, ultimately enhancing the overall resilience and flexibility of the beacon node.

Highlights

• Delayed Broadcasting: Voluntary exits submitted via the API are no longer immediately broadcast to the network. Instead, they are now inserted into the operation pool (opPool) which handles delayed broadcasting when conditions are met.
• Improved User Experience: The system now accepts early submissions of voluntary exits, providing a better user experience and increased flexibility.
• Enhanced Resilience: The changes make the system more forgiving for Distributed Validator Technology (DVT) and multi-node setups by allowing for delayed processing.
• Refined Validation Logic: The validation process for API-submitted voluntary exits has been split. validateApiVoluntaryExit now performs only 'permanent' checks (e.g., signature validation and checking if already seen), while 'transient' conditions are deferred to the opPool for later validation before broadcasting.
• New Validation Function: A new utility function, validateVoluntaryExitTransientConditions, has been introduced to specifically check the transient conditions of a voluntary exit.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces delayed broadcasting of voluntary exits, enhancing UX by accepting early submissions and improving DVT/multi-node setup tolerance. The changes involve modifying the submitPoolVoluntaryExit function in packages/beacon-node/src/api/impl/beacon/pool/index.ts to remove immediate network publishing and updating packages/beacon-node/src/chain/validation/voluntaryExit.ts to include a new validation function validateVoluntaryExitForApi for API submissions. The review focuses on correctness and maintainability, ensuring the new logic aligns with the intended behavior and adheres to best practices.

[nflaig]

I don't see those changes implemented in the PR

[nflaig]

Transient conditions will be checked by the opPool before broadcasting

doesn't seem to be implemented

[nflaig]

converting to draft until implementation is more complete