fix: delayed broadcasting of Voluntary exits

packages/beacon-node/src/api/impl/beacon/pool/index.ts

@@ -192,10 +192,18 @@ export function getBeaconPoolApi({
     },
 
     async submitPoolVoluntaryExit({signedVoluntaryExit}) {
+      // Validate the voluntary exit
       await validateApiVoluntaryExit(chain, signedVoluntaryExit);
+      // Insert into the operation pool
+      // The opPool will handle validation and delayed broadcasting
       chain.opPool.insertVoluntaryExit(signedVoluntaryExit);
+      // Emit event immediately so monitoring/logging can track it
       chain.emitter.emit(routes.events.EventType.voluntaryExit, signedVoluntaryExit);
-      await network.publishVoluntaryExit(signedVoluntaryExit);
+      // Note: Network publishing is now handled by the opPool when conditions are met
+      // instead of publishing immediately here
+      logger.info("Voluntary exit accepted and added to pool", {
+        validatorIndex: signedVoluntaryExit.message.validatorIndex,
+      });
     },
 
     async submitPoolBLSToExecutionChange({blsToExecutionChanges}) {

packages/beacon-node/src/chain/validation/voluntaryExit.ts

@@ -18,7 +18,9 @@ export async function validateApiVoluntaryExit(
   voluntaryExit: phase0.SignedVoluntaryExit
 ): Promise<void> {
   const prioritizeBls = true;
-  return validateVoluntaryExit(chain, voluntaryExit, prioritizeBls);
+  // For API submissions, we validate signature and permanent conditions
+  // Transient conditions will be checked by the opPool before broadcasting
+  return validateVoluntaryExitForApi(chain, voluntaryExit, prioritizeBls);
 }
 
 export async function validateGossipVoluntaryExit(
@@ -28,6 +30,35 @@ export async function validateGossipVoluntaryExit(
   return validateVoluntaryExit(chain, voluntaryExit);
 }
 
+async function validateVoluntaryExitForApi(
+  chain: IBeaconChain,
+  voluntaryExit: phase0.SignedVoluntaryExit,
+  prioritizeBls = false
+): Promise<void> {
+  // [IGNORE] The voluntary exit is the first valid voluntary exit received for the validator with index
+  // signed_voluntary_exit.message.validator_index.
+  if (chain.opPool.hasSeenVoluntaryExit(voluntaryExit.message.validatorIndex)) {
+    throw new VoluntaryExitError(GossipAction.IGNORE, {
+      code: VoluntaryExitErrorCode.ALREADY_EXISTS,
+    });
+  }
+
+  // Get current state for validation
+  const state = await chain.getHeadStateAtCurrentEpoch(RegenCaller.validateGossipVoluntaryExit);
+
+  // Validate signature - this is a permanent check
+  const signatureSet = getVoluntaryExitSignatureSet(state, voluntaryExit);
+  if (!(await chain.bls.verifySignatureSets([signatureSet], {batchable: true, priority: prioritizeBls}))) {
+    throw new VoluntaryExitError(GossipAction.REJECT, {
+      code: VoluntaryExitErrorCode.INVALID_SIGNATURE,
+    });
+  }
+}
+
+/**
+ * Full validation for gossip voluntary exits.
+ * Checks all conditions including transient ones.
+ */
 async function validateVoluntaryExit(
   chain: IBeaconChain,
   voluntaryExit: phase0.SignedVoluntaryExit,
@@ -50,7 +81,7 @@ async function validateVoluntaryExit(
   // relevant on periods of many skipped slots.
   const state = await chain.getHeadStateAtCurrentEpoch(RegenCaller.validateGossipVoluntaryExit);
 
-  // [REJECT] All of the conditions within process_voluntary_exit pass validation.
+  // Check all conditions here:
   // verifySignature = false, verified in batch below
   const validity = getVoluntaryExitValidity(chain.config.getForkSeq(state.slot), state, voluntaryExit, false);
   if (validity !== VoluntaryExitValidity.valid) {
@@ -66,3 +97,17 @@ async function validateVoluntaryExit(
     });
   }
 }
+
+export async function validateVoluntaryExitTransientConditions(
+  chain: IBeaconChain,
+  voluntaryExit: phase0.SignedVoluntaryExit
+): Promise<boolean> {
+  try {
+    const state = await chain.getHeadStateAtCurrentEpoch(RegenCaller.validateGossipVoluntaryExit);
+    // Check all transient conditions (verifySignature = false since we already verified it)
+    const validity = getVoluntaryExitValidity(chain.config.getForkSeq(state.slot), state, voluntaryExit, false);
+    return validity === VoluntaryExitValidity.valid;
+  } catch (_e) {
+    return false;
+  }
+}