Use CommonSpaces/Grids #4021
Draft
Use CommonSpaces/Grids #4021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefrathenrici
force-pushed
the
ne/grids
branch
from
a6e453a to
c8ece52
Compare
nefrathenrici
force-pushed
the
ne/grids
branch
from
09527fa to
0d59561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use ClimaCore's CommonGrids and CommonSpaces to create spaces.
To-do
Functions that assume horizontal space is available: CTh_vector_type,
Content
src/simulation/grids.jl: New constructors mapping ClimaAtmos spatial configurations to CommonGrids. These will be used when we add a properAtmosSimulationconstructor.src/solver/type_getters.jl:get_gridto read parsed args into the new Grid constructorsget_spaceschanged to take in a grid and construct spaces using CommonSpaces constructors