rft: clean up edmfx diagnostics #4113
Open
+416
−1,292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2025
haakon-e
force-pushed
the
he/rft-edmfx-diagnostics
branch
3 times, most recently
from
bb63713 to
f131c57
Compare
haakon-e
force-pushed
the
he/rft-edmfx-diagnostics
branch
3 times, most recently
from
078304d to
6c1143d
Compare
haakon-e
force-pushed
the
he/rft-edmfx-diagnostics
branch
5 times, most recently
from
33fc059 to
8685643
Compare
szy21
reviewed
Dec 15, 2025
src/diagnostics/edmfx_diagnostics.jl
Outdated
Comment on lines
817
to
807
| # ᶜρa⁰ = | ||
| # turbconv_model isa PrognosticEDMFX ? | ||
| # (@. lazy(ρa⁰(state.c.ρ, state.c.sgsʲs, turbconv_model))) : state.c.ρ |
szy21
reviewed
Dec 15, 2025
src/diagnostics/edmfx_diagnostics.jl
Outdated
Comment on lines
775
to
765
| # ᶜρa⁰ = | ||
| # turbconv_model isa PrognosticEDMFX ? | ||
| # (@. lazy(ρa⁰(state.c.ρ, state.c.sgsʲs, turbconv_model))) : state.c.ρ |
haakon-e
force-pushed
the
he/rft-edmfx-diagnostics
branch
from
8685643 to
320c693
Compare
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
haakon-e
force-pushed
the
he/rft-edmfx-diagnostics
branch
from
320c693 to
dc1e25f
Compare
haakon-e
force-pushed
the
he/ft-add-support-for-lazy
branch
from
dfe1e30 to
56129d5
Compare
haakon-e
force-pushed
the
he/rft-edmfx-diagnostics
branch
from
dc1e25f to
a6a64cb
Compare
haakon-e
force-pushed
the
he/rft-edmfx-diagnostics
branch
from
a6a64cb to
df1bfe8
Compare
haakon-e
force-pushed
the
he/rft-edmfx-diagnostics
branch
from
df1bfe8 to
69cd7f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the edmfx diagnostics file following CliMA/ClimaDiagnostics.jl#64, eliminates the need to return materialized fields. All returned fields are now