Quick checksum file update to support current release as of 2024-11-13 @ 2131 US/Pacific Time #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added docker-5.2-RELEASE-43.zip
added docker-5.2-RELEASE-43.zip
WaffleThief123
changed the title
the `"%s"` format string with `printf` is used to avoid potential issues related to unintended format specifiers in the variables. Here’s why it’s necessary and best practice: 1. **Avoiding Unintended Format Specifiers**: If we directly pass variables like `printf "$info"`, it may contain unintended format specifiers (like `%d`, `%s`, etc.) that can cause unexpected behavior or errors if `printf` tries to interpret them. By specifying `"%s"`, we tell `printf` to treat the variable as a plain string. 2. **Security and Stability**: Relying on the explicit `"%s"` format makes the script more robust and secure. If a variable accidentally includes a user-provided or dynamic string containing `%` characters, `printf` could interpret those as format specifiers, leading to errors or even security vulnerabilities in certain contexts. 3. **Shellcheck Compliance**: Shellcheck, a popular linting tool for shell scripts, flags this usage (`SC2059`) because treating variables as format strings can lead to unpredictable behavior. Shellcheck recommends using explicit format strings to ensure consistency and avoid errors. 4. **Readability and Maintainability**: Specifying `"%s\n"` for strings in `printf` is a clear signal to anyone reading the script that the output is intended as a simple string without embedded formatting instructions, making the code easier to understand and less error-prone.
|
oh uh, those aren't meant to be in this PR. lemme fix that real quick. |
|
ok should be good to go. If desired, I can close this PR and reopen it with just the relevant commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added checksums for takserver-docker-5.2-RELEASE-43.zip.
How I obtained checksums:
Downloaded build from TAK.gov , ran the following commands, with the following versions of sha1sum and md5sum.