Quick checksum file update to support current release as of 2024-11-13 @ 2131 US/Pacific Time #58
Commits on Nov 14, 2024
-
-
the `"%s"` format string with `printf` is used to avoid potential issues related to unintended format specifiers in the variables. Here’s why it’s necessary and best practice: 1. **Avoiding Unintended Format Specifiers**: If we directly pass variables like `printf "$info"`, it may contain unintended format specifiers (like `%d`, `%s`, etc.) that can cause unexpected behavior or errors if `printf` tries to interpret them. By specifying `"%s"`, we tell `printf` to treat the variable as a plain string. 2. **Security and Stability**: Relying on the explicit `"%s"` format makes the script more robust and secure. If a variable accidentally includes a user-provided or dynamic string containing `%` characters, `printf` could interpret those as format specifiers, leading to errors or even security vulnerabilities in certain contexts. 3. **Shellcheck Compliance**: Shellcheck, a popular linting tool for shell scripts, flags this usage (`SC2059`) because treating variables as format strings can lead to unpredictable behavior. Shellcheck recommends using explicit format strings to ensure consistency and avoid errors. 4. **Readability and Maintainability**: Specifying `"%s\n"` for strings in `printf` is a clear signal to anyone reading the script that the output is intended as a simple string without embedded formatting instructions, making the code easier to understand and less error-prone.
-
Undoing changes to main branch
Revert "fixed printf to be safer." This reverts commit 8992d84.
-
Revert "sanity correction, not everyone has a /bin/bash, and some of us are on nix" This reverts commit ca83e36.
-
Revert "fix to prevent unwanted expansion" This reverts commit 0b86ddd.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.