fix: handling of UnsignedByte #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweaks the handling of bytes within the trace generator. Whilst these were being handled correctly, the mechanism was presenting a problem for the new LtFileV2 format used within the tracer.
DavePearce
force-pushed
the
1345-feat-fix-handling-of-unsignedbyte-in-generated-tracejava-files
branch
from
d718bdc to
235d625
Compare
DavePearce
deleted the
1345-feat-fix-handling-of-unsignedbyte-in-generated-tracejava-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the handling of UnsignedByte within the trace generator. Previously, it was not handling signed values correctly.
Note
Route 8-bit column writes through a new byte path and add
Column.write(byte)to correctly handle UnsignedByte values.pkg/cmd/generate/class.go):bitwidth <= 8write asbyte(.write((byte) val)); retain legacyUnsignedByteoverload.pkg/cmd/generate/snippets.go):Columninterface addswrite(byte value)to support 8-bit writes.Written by Cursor Bugbot for commit 235d625. This will update automatically on new commits. Configure here.