Skip to content

fix: handling of UnsignedByte #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
+3 −0
Merged

fix: handling of UnsignedByte #1346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/cmd/generate/class.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,8 @@ func generateJavaModuleColumnSetter[F any](className string, methodName string,
switch {
case bitwidth == 1:
i1Builder.WriteIndentedString(fieldName, ".write(val);\n")
case bitwidth <= 8:
i1Builder.WriteIndentedString(fieldName, ".write((byte) val);\n")
case bitwidth <= 63:
i1Builder.WriteIndentedString(fieldName, ".write(val);\n")
default:
Expand Down
1 change: 1 addition & 0 deletions pkg/cmd/generate/snippets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ const javaColumn string = `
*/
public interface Column {
public void write(boolean value);
public void write(byte value);
public void write(long value);
public void write(byte[] value);
}
Expand Down