feat: support constant arrays #1347
Conversation
This adds support for encoding constant arrays, rather than just zero arrays.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| func encode_zero[T word.DynamicWord[T]](array *ZeroArray[T]) []byte { | ||
| func encode_constant[T word.DynamicWord[T]](array *ConstantArray[T]) []byte { |
There was a problem hiding this comment.
Bug: Constant value lost during array encoding
The encode_constant function only encodes the array length but discards the constant value. During decoding, decode_constant attempts to retrieve the value from the operand field (which contains bitwidth, always 0 for constant arrays), causing all constant arrays to be decoded with value 0 regardless of their original value. The constant value must be encoded and later decoded to preserve non-zero constants.
Additional Locations (1)
| encoding.Bytes = encode_zero(array.(*ZeroArray[T])) | ||
| encoding.Set(ENCODING_ZERO, bitwidth) | ||
| encoding.Bytes = encode_constant(array.(*ConstantArray[T])) | ||
| encoding.Set(ENCODING_CONSTANT, 0) |
There was a problem hiding this comment.
Bug: Constant value lost during encode/decode cycle
When encoding a ConstantArray, the operand is hardcoded to 0 and the actual constant value is never stored. During decode, encoding.Operand() returns 0, so any non-zero constant array will be incorrectly reconstructed as a zero array. The encode_constant function must encode the constant value (via the operand field) so it can be retrieved during decoding.
This adds support for encoding constant arrays, rather than just zero arrays.
Note
Introduce
ConstantArrayand its encoding (replacing zero-array), switch encoding operand to 24-bituint32, and makePadreturnMutArraywith callers updated.ConstantArray(replaces zero-array usage) withNewConstantArray, validation inAppend/Set/Pad, and propagation across builders whenbitwidth==0.MutArray.Padnow returnsMutArray[T]; update implementations (BitArray,SmallArray,StaticArray,PoolArray) and usage intrace/ArrayColumn.pad.ENCODING_ZERO→ENCODING_CONSTANT; implementencode_constant/decode_constant.uint32(Encoding.Operand/Set), adjust bitwidth handling and pool encodings to useuint32.ConstantArrayof zeros (bitwidth 0); minor variable additions to support this.Written by Cursor Bugbot for commit ffcbff4. This will update automatically on new commits. Configure here.