Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docs for funds recovery #498

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

khanti42
Copy link
Collaborator

This PR is to update the tutorial on funds recovery to match the new version of the staging environment that will be deployed to manage both funds recovery on non-deployed Cairo 0 and non-deployed Cairo 1.

@khanti42 khanti42 requested a review from a team as a code owner January 27, 2025 06:27
@khanti42 khanti42 requested review from Julink-eth and stanleyyconsensys and removed request for a team January 27, 2025 06:27
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so nit chnage

docs/tutorial-resolving-stuck-funds.md Show resolved Hide resolved
docs/tutorial-resolving-stuck-funds.md Outdated Show resolved Hide resolved
docs/tutorial-resolving-stuck-funds.md Show resolved Hide resolved
docs/tutorial-resolving-stuck-funds.md Outdated Show resolved Hide resolved
docs/tutorial-resolving-stuck-funds.md Outdated Show resolved Hide resolved
@khanti42
Copy link
Collaborator Author

This is the last step to share information with support team. If it looks good let's merged it. cc @stanleyyconsensys

@khanti42 khanti42 force-pushed the chore/tutorials-recovery-fund-update branch from 50d4dfe to a91d68d Compare January 29, 2025 11:07
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i give a pass first

@khanti42 khanti42 added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit a5cb642 Jan 31, 2025
14 checks passed
@khanti42 khanti42 deleted the chore/tutorials-recovery-fund-update branch January 31, 2025 10:10
@khanti42 khanti42 restored the chore/tutorials-recovery-fund-update branch January 31, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants