fix: floating point error #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrWeez
reviewed
Mar 29, 2025
Collaborator
MrWeez
left a comment
MrWeez
left a comment
There was a problem hiding this comment.
Why do you divide and multiply by 1000? If we store prices in cents, then we need to use 100 or am I wrong?
Collaborator
Oh, my bad, I didn't know about the existence of currencies with three decimal. |
This was
linked to
issues
Mar 30, 2025
Closed
There was a problem hiding this comment.
Copilot reviewed 45 out of 65 changed files in this pull request and generated no comments.
Files not reviewed (20)
- app/Casts/Settings/CurrencyCast.php: Language not supported
- app/Classes/PaymentExtension.php: Language not supported
- app/Extensions/PaymentGateways/MercadoPago/MercadoPagoExtension.php: Language not supported
- app/Extensions/PaymentGateways/Mollie/MollieExtension.php: Language not supported
- app/Extensions/PaymentGateways/PayPal/PayPalExtension.php: Language not supported
- app/Extensions/PaymentGateways/Stripe/StripeExtension.php: Language not supported
- app/Facades/Currency.php: Language not supported
- app/Helpers/CurrencyHelper.php: Language not supported
- app/Http/Controllers/Admin/CouponController.php: Language not supported
- app/Http/Controllers/Admin/OverViewController.php: Language not supported
- app/Http/Controllers/Admin/PaymentController.php: Language not supported
- app/Http/Controllers/Admin/ProductController.php: Language not supported
- app/Http/Controllers/Admin/SettingsController.php: Language not supported
- app/Http/Controllers/Admin/ShopProductController.php: Language not supported
- app/Http/Controllers/Admin/UserController.php: Language not supported
- app/Http/Controllers/Admin/VoucherController.php: Language not supported
- app/Http/Controllers/Auth/RegisterController.php: Language not supported
- app/Http/Controllers/HomeController.php: Language not supported
- app/Http/Controllers/ServerController.php: Language not supported
- app/Http/Controllers/StoreController.php: Language not supported
Collaborator
|
code LGTM, will spin up a test env |
Member
|
This PR seems to include breaking changes for Payments gateway we may want to release as 1.1.0 so show that |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem reported here: #1095
It also already has the fix for: #1210.
PR implements a
1000division and multiplication factor to support currencies with 3 decimal places.Edit:
In the commit 7d2c102 the way
minimum_creditsworks has been changed.Now the old
-1that was used to use the configuration value, becomesnull, to avoid users putting-1, -10, -100thinking it would work.Todo: