Skip to content

Various build fixes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Various build fixes #16

wants to merge 21 commits into from

Conversation

@mikucionisaau
Copy link
Member

@mikucionisaau mikucionisaau commented Jun 25, 2025 •
edited
Loading

  • Modernized CMake build scripts
  • Fixed compiler warnings

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mikucionisaau
Fixed CMake scripts for Ubuntu-24.04 (cmake-3.28)
f313ce1
@mikucionisaau
Simplified the cmake scripts
caa772c
@mikucionisaau
Added presets and README for quick build, test, install
418b206
@mikucionisaau
Minor fixes to README
ccf17ea
@mikucionisaau
Added back the compiler warnings and fixed them and some more readabi…
4ab96f2 
…lity cleanup
@mikucionisaau
Refactoed key parsing to fallback to stream parsing in case from_char…
346a66a 
… is not provided (AppleClang)
@mikucionisaau
Removed redundant static_assert (used for testing has_from_chars)
e10eb0e
@mikucionisaau
Simplified dependency tracking in CMake (failed with cmake-4)
50cc95d
@mikucionisaau
Moved from_chars check
30cc892
@mikucionisaau
isolated checking for from_chars (AppleClang is such a headache)
ce155b7
@mikucionisaau
Isolated parse_key into a separate header to debug AppleClang issues
bb80d4f
@mikucionisaau
Fixed parse_key
d2ac671 
C++ standard and AppleClang insist that constexpr is evaluated at CT only when the condition depends on template parameters
https://eel.is/c++draft/stmt.if#2
@mikucionisaau
Fixed parse?keys for sure now
2b0488c
@mikucionisaau
Simplified parsing key
fc366a8
@mikucionisaau
Removed leak sanitizer as AppleClang does not support it and AddressS…
279655a 
…anitizer seems to cover leak checking
@mikucionisaau mikucionisaau force-pushed the update-build branch 7 times, most recently from 174a82e to ac9e745 Compare June 30, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikucionisaau @CLAassistant