fix: #3591 abandoned delayed request also fires an event #3602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dsilhavy If possible, I hope this could be considered in 3.2.2 :) |
Collaborator
|
@orange4glace 3.2.2 was already released on 13th April. If you need this change in version 3.x you will need to merge this against your local branch. The next dash.js release will be 4.0 |
Collaborator
|
@orange4glace Sorry for the delay on my end. We are currently working on version 4.0 including major changes to the general structure of dash.js. Can you rebase your PR against the latest development branch please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3591
I have tested with single-track + multi-resolution (more than 100+ times with many different manifests), it worked without any problems and fixed #3591,
although I am not 100% sure this code change will not cause a side-effect or not. (code changes in 4.0 also might need to be considered for the future?)
Please give some thoughts! :)