Skip to content

fix: #3591 abandoned delayed request also fires an event #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fix: #3591 abandoned delayed request also fires an event #3602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
364d23d
fix: #3591 abandoned delayed request also fires an event
orange4glace Apr 11, 2021
0af318d
Merge branch 'development' into fix/3591
orange4glace Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/streaming/net/HTTPLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,10 @@ function HTTPLoader(cfg) {
loader.load(httpRequest);
} else {
// delay
let delayedRequest = { httpRequest: httpRequest };
let delayedRequest = {
httpRequest: httpRequest,
config: config
};
delayedRequests.push(delayedRequest);
delayedRequest.delayTimeout = setTimeout(function () {
if (delayedRequests.indexOf(delayedRequest) === -1) {
Expand Down Expand Up @@ -366,7 +369,13 @@ function HTTPLoader(cfg) {
});
retryRequests = [];

delayedRequests.forEach(x => clearTimeout(x.delayTimeout));
delayedRequests.forEach(x => {
clearTimeout(x.delayTimeout);
// abort request in order to trigger LOADING_ABANDONED event
if (x.config.request && x.config.abort) {
x.config.abort(x.config.request);
}
});
delayedRequests = [];

requests.forEach(x => {
Expand Down