Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few TODO's #5477

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Add a few TODO's #5477

merged 1 commit into from
Mar 25, 2025

Conversation

watson
Copy link
Collaborator

@watson watson commented Mar 25, 2025

What does this PR do?

Add 3 TODO comments.

Motivation

These are things I discovered while working on a different PR.

Plugin Checklist

Additional Notes

@watson watson requested review from a team as code owners March 25, 2025 07:52
@watson watson self-assigned this Mar 25, 2025
Copy link
Collaborator Author

watson commented Mar 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Mar 25, 2025

Overall package size

Self size: 9 MB
Deduped: 101.53 MB
No deduping: 102.04 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@watson watson force-pushed the watson/add-todos branch from 2e04edc to de94c82 Compare March 25, 2025 07:53
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 25, 2025

Datadog Report

Branch report: watson/add-todos
Commit report: f9b0096
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 797 Passed, 0 Skipped, 11m 52.07s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 25, 2025

Benchmarks

Benchmark execution time: 2025-03-25 08:04:04

Comparing candidate commit de94c82 in PR branch watson/add-todos with baseline commit fac8988 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 919 metrics, 14 unstable metrics.

@BridgeAR BridgeAR merged commit ca101dc into master Mar 25, 2025
430 checks passed
@BridgeAR BridgeAR deleted the watson/add-todos branch March 25, 2025 23:16
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (fac8988) to head (de94c82).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #5477       +/-   ##
==========================================
- Coverage   79.58%       0   -79.59%     
==========================================
  Files         510       0      -510     
  Lines       22923       0    -22923     
==========================================
- Hits        18244       0    -18244     
+ Misses       4679       0     -4679     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rochdev rochdev mentioned this pull request Mar 26, 2025
rochdev pushed a commit that referenced this pull request Mar 26, 2025
rochdev pushed a commit that referenced this pull request Mar 26, 2025
papandreou added a commit to papandreou/dd-trace-js that referenced this pull request Apr 2, 2025
* tag 'v5.45.0': (141 commits)
  v5.45.0
  fix duplicate custom metrics when multiple tags are used (DataDog#5491)
  report rc.client_id tag when rc is enabled (DataDog#5467)
  add sdk.event to communicate a login or custom event (DataDog#5462)
  add matrix strategy to debugger ci job (DataDog#5450)
  chore(llmobs): add telemetry metrics for dropped span/eval payloads (DataDog#5469)
  chore(llmobs): Add llmobs product enabled telemetry metrics (DataDog#5475)
  chore(langchain): fix test flakiness (DataDog#5461)
  v5.44.0
  Fix iast flaky code injection tests (DataDog#5460)
  Add a few TODO's (DataDog#5477)
  chore(llmobs): add span size telemetry metrics (DataDog#5468)
  fix memory leak in runtime.node.heap.* metrics (DataDog#5476)
  waf requests telemetry metrics (DataDog#5384)
  feat(llmobs): add vertexai plugin (DataDog#5413)
  Fix logging null when debugging and sending data without any error (DataDog#5480)
  [test optimization] [SDTEST-1720] Change capabilities tagging to send version number (DataDog#5463)
  [test optimization] [SDTEST-1630] Attempt to fix flaky tests implementation (DataDog#5429)
  fix wrong test error message when expected span was not received (DataDog#5447)
  make cache action unix compatible and update test agent (DataDog#5464)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants