test(fuzz): add fuzzing for dpapi-pdu structures
#412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBestTvarynka
force-pushed
the
feat/dpapi-pdu-fuzzing
branch
from
1cf50e2 to
aa8b2c5
Compare
CBenoit
reviewed
Apr 8, 2025
Comment on lines
+27
to
+30
| "crates/dpapi-pdu", | ||
| "crates/dpapi-fuzzing", | ||
| "crates/dpapi-pdu", | ||
| "crates/dpapi-fuzzing", |
There was a problem hiding this comment.
Oh, yes. I think I accidentally added it during conflicts resolving
CBenoit
reviewed
Apr 9, 2025
Comment on lines
+13
to
+17
| pub fn round_trip(any: AnyStruct) { | ||
| let mut buf = WriteBuf::new(); | ||
|
|
||
| if let Ok(name) = any.encode(&mut buf) { | ||
| let round_tripped_struct = |
There was a problem hiding this comment.
note: Those are called "oracles". I think it would be slightly better to put all the oracles into a oracle module.
CBenoit
reviewed
Apr 9, 2025
| let floor_length = src.read_u16(); | ||
| let tower = (0..floor_length) | ||
| .map(|_| Floor::decode_owned(src)) | ||
| .collect::<DecodeResult<Vec<Floor>>>()?; | ||
|
|
||
| // invalid tower_length can lead to invalid padding and corrupted fields. |
There was a problem hiding this comment.
style: Proper sentence for comments:
Suggested change
| // invalid tower_length can lead to invalid padding and corrupted fields. | |
| // Invalid tower_length can lead to invalid padding and corrupted fields. |
CBenoit
reviewed
Apr 9, 2025
Comment on lines
+12
to
+14
| dpapi-fuzzing = { path = "../crates/dpapi-fuzzing" } | ||
| libfuzzer-sys = "0.4" | ||
| sspi = { path = ".." } |
There was a problem hiding this comment.
note:
Suggested change
| dpapi-fuzzing = { path = "../crates/dpapi-fuzzing" } | |
| libfuzzer-sys = "0.4" | |
| sspi = { path = ".." } | |
| dpapi-fuzzing.path = "../crates/dpapi-fuzzing" | |
| libfuzzer-sys = "0.4" | |
| sspi.path = ".." |
CBenoit
approved these changes
Apr 9, 2025
CBenoit
changed the title
dpapi-pdu structuresdpapi-pdu structures
|
Argh, I didn’t notice it was against another PR branch…! If the intention was to merge this PR later, I think it’s better to mark it as draft to help avoiding this kind of mistakes 🙂 |
Oh, okay. I will take it into account |
TheBestTvarynka
added a commit
that referenced
this pull request
Apr 9, 2025
This reverts commit 187d6f5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I decided to add fuzzing to
dpapi-pducrate. Because we have a lot of decoding/encoding there.It wasn't hard to implement it. It was much harder to fix bugs found by fuzzing.