Multiple fixes #196
Merged
Multiple fixes #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
reviewed
May 13, 2020
| @@ -82,7 +82,6 @@ async def _build_trader(self): | |||
|
|
|||
| async def _build_modes(self): | |||
| try: | |||
| init_trading_mode_config(self.config) | |||
There was a problem hiding this comment.
By OctoBot, it's related to the advanced manager (when we figure out advanced classes). Maybe we should move it into the tentacle manager if we decide it's its role to manage advanced classes in the future
There was a problem hiding this comment.
Yes it should be better in Tentacle manager, I don't think Octobot have to do that.
There was a problem hiding this comment.
| @@ -350,7 +350,7 @@ def _load_config_symbols_and_time_frames(self): | |||
| client = self.exchange.client | |||
| if client: | |||
| self.client_symbols = client.symbols | |||
| self.client_time_frames = list(client.timeframes.values()) if hasattr(client, "timeframes") else [] | |||
| self.client_time_frames = list(client.timeframes) if hasattr(client, "timeframes") else [] | |||
There was a problem hiding this comment.
yes, list(dict) returns a list of its keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.