Skip to content

DYN-9210: Prevent adding null nodes and transient nodes into groups #16406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

chubakueno
Copy link
Contributor

Purpose

Under some order of operations, nodes with a null model are generating a null reference exception when dragged into groups. This PR prevents adding null nodes and transient nodes into groups.

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Prevent adding null nodes and transient nodes into groups.

Reviewers

@DynamoDS/synapse

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9210

@johnpierson johnpierson added this to the 3.6 milestone Jul 17, 2025
@BogdanZavu
Copy link
Contributor

LGTM!

@chubakueno chubakueno merged commit d0824c4 into DynamoDS:master Jul 18, 2025
26 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 18, 2025
Copy link

Successfully created backport PR for RC3.6.0_master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants