Skip to content

[Cherry-pick] DYN-9210: Prevent adding null nodes and transient nodes into groups #16408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

github-actions[bot]
Copy link

Cherry-pick of #16406 to RC3.6.0_master

Purpose

Under some order of operations, nodes with a null model are generating a null reference exception when dragged into groups. This PR prevents adding null nodes and transient nodes into groups.

Declarations

Check these if you believe they are true

  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB
  • This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

Prevent adding null nodes and transient nodes into groups.

Reviewers

@DynamoDS/synapse

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@zeusongit zeusongit merged commit 12da694 into RC3.6.0_master Jul 18, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants