BugFix: Incorrect Site Navigation on Search #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/Esri/arcgis-maps-sdk-dotnet-toolkit into pratham/toolkit-floorfilter-bug-fix
- Changed `SearchPlaceholder` to use correct resource "FloorFilterFilterSearchPlaceholder". - Removed unused `InitializeLocalizedStrings` method from `FloorFilter`. - Refactored `HandleSearchText_Changed` in `FloorFilterBrowseSitesPage` for improved search functionality and UI handling.
dotMorten
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When typing any character from "E" or "W" in the "Select a Site" search field, the app would automatically navigate to the "West" site, regardless of the user's intended input.
The search logic was too aggressive, causing unintended site selection based on partial matches.
Updated the search placeholder text to use the correct localized resource (FloorFilterFilterSearchPlaceholder) for better clarity and consistency.
New logic prevents automatic navigation or selection when only partial matches are found.