Skip to content

Draft version of veterancy effects for UEF and Cybran #6155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Fichom
Copy link
Contributor

@Fichom Fichom commented May 4, 2024

Description of the proposed changes

Draft effects for veterancy for UEF and Cybran

2024-05-03.23-48-33.mp4

Testing done on the proposed changes

Additional context

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@arch625
Copy link

arch625 commented May 5, 2024

This is cool, I'd love to see it added. I think the visual effect should be a bit more concentrated on the exact unit so when you have a larger army you can see more clearly which unit got the vet.

@arch625
Copy link

arch625 commented May 5, 2024

In CNC3 I recall the unit just had the veterancy icon appear overhead when it reached a new rank, I think the same could work here, e.g. for UEF you just see the exact rank (⭐,⭐⭐, ⭐⭐⭐, etc.) appear above the unit with a little burst of color around it.

@Garanas
Copy link
Member

Garanas commented May 12, 2024

@Fichom the effect now spawns for UEF units when they gain veterancy. I've also scaled the effect based on the unit size, so that it's more concentrated (by the suggestion of @arch625 ). See also:

veterancy-scale-by-size.mp4

From a testing perspective everything is the same - you can edit the effects table and it shows you how the effect would appear as if the unit gained veterancy.

@MrRowey MrRowey added area: ui Anything to do with the User Interface of the Game area: graphics Anything Related to the Game Graphics labels May 15, 2024
@Garanas Garanas changed the base branch from deploy/fafdevelop to develop June 1, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Anything Related to the Game Graphics area: ui Anything to do with the User Interface of the Game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants