Rework UnitsTooltip to use Layouter to fix its UI scaling #6175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example UEF Mex in Russian and US localization also fix whitespace typo and use LOC instead of LOCF (LOCF doesn't work here)
should upvalue table and string functions later
for a cleaner diff next commit
-1 px downwards offset on icons compared to before
it doesn't even work because it doesn't convert ticks to seconds correctly
lL1l1
added
type: bug
area: ui
Garanas
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Fixes #5424 by rewriting unit tooltips using the Layouter. In addition, fixes localized empty strings appearing as empty parentheses in unit names (for example UEF mex in RU/US were "T3 Mass Exctractor ()"), and changes the buildtime display to just buildtime ticks instead of a convoluted MM:SS format.
100%:
80%:
150%:
Testing done on the proposed changes
Go to options -> interface -> UI Scale -> 150% and then open a skirmish -> options -> restrictions and mouse over the units in a circle to make sure all 4 variants of the tooltip work as expected (variants that move which corner of the tooltip is attached as to avoid going off the screen). Repeat for 80% and 100% scale.
Checklist