Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader rework #6485

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Shader rework #6485

wants to merge 7 commits into from

Conversation

BlackYps
Copy link
Contributor

@BlackYps BlackYps commented Oct 20, 2024

Depends on #6452, so the diff will be misleading until that one is merged.

Now every shader is capable of using the new, better way of calculating the water absorption. The only requirement is that the light multiplier is bigger than 2.1. This is good, because the mesh shader doesn't know what terrain shader is in use and has worked like this before. This could lead to unfitting results, if the light multiplier was big enough, but a terrain shader was used that only supported the legacy water calculation. This is now fixed.

I also made the decals able to use pbr light calculations. Now they behave consistently like the ground they are on. (Also the map editor does this automatically and we can't prevent it, so it helps the editor produce results that are consistent with the game.)
We could also do this for splats, I haven't decided on that yet.

One thing about the decals is that they theoretically have a texture to define the specularity (or roughness), but this texture was black for all decals that I tested. I don't know if there are any decals that have this defined.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@BlackYps BlackYps added the area: graphics Anything Related to the Game Graphics label Oct 20, 2024
@BlackYps BlackYps marked this pull request as ready for review October 26, 2024 21:05
@BlackYps BlackYps requested a review from Garanas October 26, 2024 21:05
Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. The additional documentation is also highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Anything Related to the Game Graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants