-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix depth charges not applying the ProjectilesToDeflect
blueprint field
#6507
Conversation
ProjectilesToDeflect
field
ProjectilesToDeflect
fieldProjectilesToDeflect
blueprint field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Depth charge" is confusing with the depth charge weapon. I think we should use "Anti-Torpedo Flare" because that makes sense when you know about Aeon tactical missile flares, and the name is already used by the Mermaid, Brick, Megalith, and Barracuda. UEF's display name is "Smart Charge AntiTorpedo" and Salem is an outlier with "Anti Torpedo Solution".
I tested it out with UEF destroyers and when I set the |
I agree, but we should process that in a separate pull request. It's also a little tricky because if we change the names (of the Lua classes) then we'll also break mod compatibility. |
Description of the proposed changes
Fix an issue where the blueprint field
ProjectilesToDeflect
of a depth charge was ignored. It would always default to the value3
.Testing done on the proposed changes
In the following test case I increased the redirect count of the depth charge of the UEF Destroyer to 10.
fix-depth-charge.mp4
Checklist