fix GetAngleInBetween parameter references

[relent0r]

Description of the proposed changes

Fixes a small bug in the refactor of GetAngleInBetween. It was references indexes but the function that calls it is using named keys.

fixes #6524

p.s this needs someone smarter than me to validate I'm actually fixes this correctly as I'm unsure.

Testing done on the proposed changes

Tested to make sure the scathis does not error and shoots things.

Checklist

• Changes are annotated, including comments where useful
• Changes are documented in the changelog for the next game version

[lL1l1]

Good find for my refactor messing up the mathematics, it should indeed be z1 * z1 and z2 * z2.

I tested the changed math with my fixed Scathis and they make the fake barrels align with the aim barrel more accurately (when you view the wireframe skeletons).

[lL1l1]

Note: caused by #6438
You can also simply add this PR's number to the snippet other.6438.md for the changelog requirement, since it is essentially part of the same patch.

[relent0r]

Good find for my refactor messing up the mathematics, it should indeed be z1 * z1 and z2 * z2.

I tested the changed math with my fixed Scathis and they make the fake barrels align with the aim barrel more accurately (when you view the wireframe skeletons).

Thanks, I can see your making the updates in 6528 for function call, once you merge that in I'll update this to match.