Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rounding in weapon tracking radius sanitization #6536

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Nov 15, 2024

Description of the proposed changes

Fixes a bug where most weapons got 1.0 tracking radius because they were set to 1.05 but floored to 1.0.

Testing done on the proposed changes

Spawn a unit and see that it does aim at targets at 1.05x its range.

Additional context

  • I was investigating why T3 mobile artillery wasn't unpacking when targets were outside on the edge of its range in reponse to this Discord suggestion for a manual pack/unpack for T3 mobile artillery when I found out that the tracking radius wasn't applying for any units. It still doesn't apply for T3 mobile arty because of NeedsUnpack = true. Working around that engine AI logic adds lots of conditionals to the lua which is buggy, and deploying when targets are nearby is possibly undesired anyway.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added the area: unit-blueprint related to issues in unit blueprints (*_unit.bp) label Nov 15, 2024
@lL1l1 lL1l1 marked this pull request as ready for review November 15, 2024 17:50
@lL1l1 lL1l1 requested a review from Garanas November 15, 2024 17:50
@lL1l1 lL1l1 merged commit 454dfc4 into FAForever:develop Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: unit-blueprint related to issues in unit blueprints (*_unit.bp)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants