Fix unbuilt units not being destroyed in factories when mobile build orders are cancelled #6700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
You can do "OnStopBuild" with an unfinished unit by cancelling a
BuildMobileorder on the ground. This gets the factory locked up since there is no way to remove the unfinished unit.Description of the proposed changes
Destroy unbuilt units in FactoryUnit.OnStopBuild
Testing done on the proposed changes
An unfinished unit no longer remains in the factory after the mobile build order is cancelled.
Copy-paste command for testing:
Checklist