Skip to content

Fix treads spawning for units that are on a transport #6881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix treads spawning for units that are on a transport #6881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b45376
Add early exit conditions to prevent creating tread splats
Garanas Jun 28, 2025
df2e37d
Add a changelog snippet
Garanas Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/fix.6881.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- (#6881) Fix tread splats spawning for units that are attached to a transport
13 changes: 13 additions & 0 deletions lua/defaultcomponents.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,14 +417,27 @@ TreadComponent = ClassSimple {

---@param self Unit | TreadComponent
CreateMovementEffects = function(self)
-- early exit: do not create treads if we do not have the blueprint
local treads = self.TreadBlueprint
if not treads then
return
end

-- early exit: do not create treads if we're in the air or on water
local layer = self.Layer
if layer == "Air" or layer == "Water" then
return
end

-- early exit: do not create treads if we are attached to something (like a transport)
if self:IsUnitState("Attached") then
return
end

if treads.ScrollTreads then
self:AddThreadScroller(1.0, treads.ScrollMultiplier or 0.2)
end

local treadMarks = treads.TreadMarks
local treadType = self.TerrainType.Treads
if treadMarks and treadType and treadType ~= 'None' then
Expand Down