Skip to content

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Jul 20, 2025

Description of the proposed changes

Extends the annotations to indicate that some of them also work with a list of unit identifiers, such as uel0001.

Testing done on the proposed changes

Repurposed a hotkey to call the functions from the UI with test data.

Checklist

@Garanas Garanas added the area: ui Anything to do with the User Interface of the Game label Jul 20, 2025
@Garanas Garanas marked this pull request as ready for review July 20, 2025 07:51
@4z0t 4z0t changed the title Improve annotations for entity category functies Improve annotations for entity category functions Jul 30, 2025
Copy link
Member

@4z0t 4z0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo.

---@overload fun (category: EntityCategory, unit: Projectile): boolean
---@overload fun (category: EntityCategory, unit: Blip): boolean
---@overload fun (category: EntityCategory, unit: Prop): boolean
---Returns true iff the entity or blueprint id is of the given category.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---Returns true iff the entity or blueprint id is of the given category.
---Returns true if the entity or blueprint id is of the given category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Anything to do with the User Interface of the Game

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants