-
Notifications
You must be signed in to change notification settings - Fork 243
Improve resolution of available support factories during ACU ehnancement to higher teches #6892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Improve resolution of available support factories during ACU ehnancement to higher teches #6892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing is super broken but I caught an edge case and there's code at the end to clean up.
Spawn all ACUs command:
CreateUnitAtMouse('ual0001', 0, -2.00, 0.00, -0.00000)
CreateUnitAtMouse('xsl0001', 0, 2.00, 0.00, -0.00000)
CreateUnitAtMouse('url0001', 0, 7.00, 0.00, -0.00000)
CreateUnitAtMouse('uel0001', 0, -7.00, 0.00, -0.00000)
Co-authored-by: lL1l1 <[email protected]>
These AI extensions sometime replace what I didn't want to replace 🤕 |
supportFactories = supportFactories + supportCategory | ||
end | ||
newBuildableCategories = supportFactories * supportFactories | ||
newBuildableCategories = newBuildableCategories * supportFactories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function says it returns a modified list of buildables, not just the valid support factories. Idk why the UI works when you return only support factories.
newBuildableCategories = newBuildableCategories * supportFactories | |
newBuildableCategories = newBuildableCategories - categories.SUPPORTFACTORY + supportFactories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your suggestion is invalid because It makes all faction HQs to be buildable by any other
Co-authored-by: lL1l1 <[email protected]>
Description of the proposed changes
Reduces number of required selections down to 2 (was 7) that were resolving available support factories for construction during ACU enhancement to higher teches.
Testing done on the proposed changes
Additional context.
In perfect world we'd like to report from sim that we have hq of certain category and thus have available categories for support factories.
Checklist