-
Notifications
You must be signed in to change notification settings - Fork 248
changed sparky Guard scan radius from 26->8 #7001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughA changelog entry and unit balance adjustment reducing the GuardScanRadius parameter of the Sparky unit (XEL0209) from 26 to 8, limiting its guard and sensing range for enemy unit engagement. Changes
Possibly related issues
Poem
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@changelog/snippets/BalanceFix7000.md`:
- Line 1: The changelog file BalanceFix7000.md contains a leading BOM/zero‑width
character and an incorrect PR reference; open the file and remove the invisible
character at the start of the file, then update the entry text (the line
containing "GuardScanRadius from 26->8. Sparkies will not stop reclaiming...")
to reference `#7001` instead of `#7000` so the changelog matches the current PR.
| @@ -0,0 +1 @@ | |||
| - (#7000) GuardScanRadius from 26->8. Sparkies will not stop reclaiming to pursue enemy units from such a large range anymore. No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix changelog reference and remove BOM.
The entry references #7000 but this PR is #7001, and the leading BOM/zero‑width character can cause formatting/tooling glitches.
📝 Proposed fix
-- (`#7000`) GuardScanRadius from 26->8. Sparkies will not stop reclaiming to pursue enemy units from such a large range anymore.
+- (`#7001`) GuardScanRadius from 26->8. Sparkies will not stop reclaiming to pursue enemy units from such a large range anymore.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - (#7000) GuardScanRadius from 26->8. Sparkies will not stop reclaiming to pursue enemy units from such a large range anymore. | |
| - (`#7001`) GuardScanRadius from 26->8. Sparkies will not stop reclaiming to pursue enemy units from such a large range anymore. |
🤖 Prompt for AI Agents
In `@changelog/snippets/BalanceFix7000.md` at line 1, The changelog file
BalanceFix7000.md contains a leading BOM/zero‑width character and an incorrect
PR reference; open the file and remove the invisible character at the start of
the file, then update the entry text (the line containing "GuardScanRadius from
26->8. Sparkies will not stop reclaiming...") to reference `#7001` instead of
`#7000` so the changelog matches the current PR.
|
requesting reviews from: |
Description of the proposed changes
Gifs:
Default.26.GSR.mp4
changed.8.GSR.mp4
Notice how in the current game, Sparkies will stop reclaiming to chase a target when it reaches within 26 range (the red ring is 18 range and grey rings are 44 range).
With 8 GSR Sparkies will continue to reclaim even with an enemy in its attack range, and will fire to defend itself, while reclaiming.
video with commentary showing 8 GSR
video with commentary showing 26 GSR
Guard scan radius is the distance a unit will initiate pursuit of enemies/reclaim from their patrol or attack move route. Its the reason why when you give an attack move engys may run backwards to get the trees behind them or branch off to get reclaim adjacent to the route. Implications of reducing this in non-combat scenarios will be shown.
Testing done on the proposed changes
Checked if the feature works in a development enviromont following this guide.
Played some games with the a mod enabled that changed the value via blueprint hooking.
Tested Sparkies performance on reclaiming without enemies nearby and they will not voyage super far from the patrol or reclaim route like a regular engineer. Making them require more precision.
Tested Sparkies vs regular engineers in a reclaim field, Sparkies no longer, stop reclaiming to kill the opposing engineers, but once they get in range will shoot them while reclaiming.
Additional context
Forum post discussion:
https://forum.faforever.com/topic/9827/reduce-sparky-guardscanradius-from-26-8?_=1769034106081
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.