Implements the perp operator as a class #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
force-pushed
the
perp_operator_rebase
branch
from
d9d7ff3
to
3206146
Compare
dham
previously requested changes
Jul 26, 2023
mscroggs
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
perpoperation is currently implemented as function:This create problems for the form manipulation language used in Firedrake's Gusto package. When we try to use UFL's replacement routines on a perp-ed vector, the perp-ed vector is not recognised as an operation on the original vector.
This PR addresses this by implementing
perpas a classPerp, just as other operations such as the cross product are implemented.