Skip to content

686 logging typos#688

Closed
kevinpowell1 wants to merge 3 commits intomainfrom
686-logging-typos
Closed

686 logging typos#688
kevinpowell1 wants to merge 3 commits intomainfrom
686-logging-typos

Conversation

@kevinpowell1
Copy link
Contributor

@kevinpowell1 kevinpowell1 commented Sep 28, 2023

No description provided.

@kevinpowell1 kevinpowell1 linked an issue Sep 28, 2023 that may be closed by this pull request
Logging Typos #686
Closed
kevinpowell1
kevinpowell1 commented Sep 28, 2023
View reviewed changes
Copy link
Contributor Author

@kevinpowell1 kevinpowell1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more typo fixes

@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.75%. Comparing base (c987869) to head (3b7fd1f).
Report is 118 commits behind head on main.

Files with missing lines Patch % Lines
...ng_file_transformation/mapping_file_mapper_base.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   70.70%   70.75%   +0.05%     
==========================================
  Files         101      101              
  Lines       11038    11030       -8     
  Branches     1335     1331       -4     
==========================================
  Hits         7804     7804              
+ Misses       2941     2937       -4     
+ Partials      293      289       -4
Flag Coverage Δ
unittests 70.75% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

bltravis
bltravis reviewed Sep 29, 2023
View reviewed changes
pyproject.toml
Copy link
Collaborator

@bltravis bltravis Sep 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinpowell1 Looks like this snuck in. Can we remove it, please?

bltravis
bltravis requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@bltravis bltravis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions inline.

src/folio_migration_tools/mapping_file_transformation/organization_mapper.py
)
else:
self.address_categories_map = None
self.address_categories_map = RefDataMapping(
Copy link
Collaborator

@bltravis bltravis Sep 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like fixing typos. Was this included intentionally?

@bltravis
Copy link
Collaborator

bltravis commented Oct 9, 2023

@kevinpowell1 Can you have a look at this?

@bltravis
Copy link
Collaborator

bltravis commented Nov 30, 2024

This was fixed in #804

@bltravis bltravis closed this Nov 30, 2024
@bltravis bltravis deleted the 686-logging-typos branch November 30, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bltravis bltravis bltravis requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logging Typos

2 participants

@kevinpowell1 @bltravis