-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
686 logging typos #688
base: main
Are you sure you want to change the base?
686 logging typos #688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more typo fixes
Codecov Report
@@ Coverage Diff @@
## main #688 +/- ##
==========================================
+ Coverage 70.70% 70.75% +0.05%
==========================================
Files 101 101
Lines 11038 11030 -8
Branches 1335 1331 -4
==========================================
Hits 7804 7804
+ Misses 2941 2937 -4
+ Partials 293 289 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinpowell1 Looks like this snuck in. Can we remove it, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions inline.
) | ||
else: | ||
self.address_categories_map = None | ||
self.address_categories_map = RefDataMapping( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem like fixing typos. Was this included intentionally?
@kevinpowell1 Can you have a look at this? |
No description provided.