Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

686 logging typos #688

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ positional arguments:
optional arguments:
-h, --help show this help message and exit
--okapi_password OKAPI_PASSWORD
pasword for the tenant in the configuration file
password for the tenant in the configuration file
--base_folder_path BASE_FOLDER_PATH
path to the base folder for this library. Built on migration_repo_template
```
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinpowell1 Looks like this snuck in. Can we remove it, please?

Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ argparse-prompt = "^0.0.5"
deepdiff = "^6.2.3"
pyaml = "^21.10.1"
httpx = "^0.23.3"
ipykernel = "^6.25.2"
python-i18n = "^0.3.9"

[tool.poetry.group.dev.dependencies]
Expand Down
2 changes: 1 addition & 1 deletion src/fetch_default_ref_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def main():
def get_ref_data_from_github_folder(owner, repo, folder_path: str):
ret_arr = []
try:
logging.info("Using GITHB_TOKEN environment variable for Gihub API Access")
logging.info("Using GITHUB_TOKEN environment variable for Github API Access")
github_headers = {
"content-type": "application/json",
"User-Agent": "Folio Client (https://github.com/FOLIO-FSE/FolioClient)",
Expand Down
2 changes: 1 addition & 1 deletion src/folio_migration_tools/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def parse_args():
)
parser.add_argument(
"--okapi_password",
help="pasword for the tenant in the configuration file",
help="password for the tenant in the configuration file",
secure=True,
)
parser.add_argument(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@
missing_keys_in_record,
)
else:
logging.info("All maped legacy fields are in the legacy object")
logging.info("All mapped legacy fields are in the legacy object")

Check warning on line 791 in src/folio_migration_tools/mapping_file_transformation/mapping_file_mapper_base.py

View check run for this annotation

Codecov / codecov/patch

src/folio_migration_tools/mapping_file_transformation/mapping_file_mapper_base.py#L791

Added line #L791 was not covered by tests

def get_ref_data_tuple_by_code(self, ref_data, ref_name, code):
return self.get_ref_data_tuple(ref_data, ref_name, code, "code")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def get_latest_acq_schemas_from_github(owner, repo, module, object):
}

if os.environ.get("GITHUB_TOKEN"):
logging.info("Using GITHB_TOKEN environment variable for Gihub API Access")
logging.info("Using GITHUB_TOKEN environment variable for Github API Access")
github_headers["authorization"] = f"token {os.environ.get('GITHUB_TOKEN')}"

# Start talkign to GitHub...
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def __init__(
):
# Build composite organization schema
if os.environ.get("GITHUB_TOKEN"):
logging.info("Using GITHB_TOKEN environment variable for Gihub API Access")
logging.info("Using GITHUB_TOKEN environment variable for Github API Access")
organization_schema = OrganizationMapper.get_latest_acq_schemas_from_github(
"folio-org", "mod-organizations-storage", "mod-orgs", "organization"
)
Expand Down Expand Up @@ -131,38 +131,26 @@ def set_up_reference_data_mapping(
"categories",
)

if address_categories_map:
self.address_categories_map = RefDataMapping(
*categories_shared_args, address_categories_map, "value", "CategoriesMapping"
)
else:
self.address_categories_map = None
self.address_categories_map = RefDataMapping(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like fixing typos. Was this included intentionally?

*categories_shared_args, address_categories_map, "value", "CategoriesMapping"
)

if email_categories_map:
self.email_categories_map = RefDataMapping(
*categories_shared_args, email_categories_map, "value", "CategoriesMapping"
)
else:
self.email_categories_map = None
self.email_categories_map = RefDataMapping(
*categories_shared_args, email_categories_map, "value", "CategoriesMapping"
)

if phone_categories_map:
self.phone_categories_map = RefDataMapping(
*categories_shared_args, phone_categories_map, "value", "CategoriesMapping"
)
else:
self.phone_categories_map = None

if organization_types_map:
self.organization_types_map = RefDataMapping(
self.folio_client,
"/organizations-storage/organization-types",
"organizationTypes",
organization_types_map,
"name",
"OrganizationTypeMapping",
)
else:
self.organization_types_map = None
self.phone_categories_map = RefDataMapping(
*categories_shared_args, phone_categories_map, "value", "CategoriesMapping"
)

self.organization_types_map = RefDataMapping(
self.folio_client,
"/organizations-storage/organization-types",
"organizationTypes",
organization_types_map,
"name",
"OrganizationTypeMapping",
)

@staticmethod
def get_latest_acq_schemas_from_github(owner, repo, module, object):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ def load_ref_data_mapping_file(
),
)
logging.info(
"%s will be used for determinig %s",
"%s will be used for determining %s",
", ".join(ref_data_map[0].keys()),
folio_property_name,
)
Expand Down
Loading