Made sprites rendering more compliant to GoldSrc #2188
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewa-j
reviewed
Jun 5, 2025
| @@ -748,6 +748,8 @@ void R_DrawSpriteModel( cl_entity_t *e ) | |||
| { | |||
| case kRenderTransAlpha: | |||
| pglDepthMask( GL_FALSE ); | |||
| pglEnable( GL_BLEND ); | |||
There was a problem hiding this comment.
Это ничего не меняет, оно же провалится вниз и сделает эти же два вызова второй раз
lewa-j
reviewed
Jun 5, 2025
| @@ -756,6 +758,9 @@ void R_DrawSpriteModel( cl_entity_t *e ) | |||
| break; | |||
| case kRenderGlow: | |||
| pglDisable( GL_DEPTH_TEST ); | |||
| pglDepthMask( GL_FALSE ); | |||
| pglBlendFunc( GL_ONE, GL_ONE ); | |||
There was a problem hiding this comment.
Нкоманды выше и ниже просто вызовуться второй раз и ничего не поменяют. А эта не сработает потому что BlendFunc ниже затрёт её.
lewa-j
reviewed
Jun 5, 2025
| // all sprites can have color | ||
| pglTexEnvi( GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE ); | ||
| if( e->curstate.rendermode == kRenderTransColor ) | ||
| pglTexEnvi( GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_ALPHA ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not tested it and cannot be sure that it doesn't conflicts with some Xash-specific features related to sprites. So I'll summon testers to do it.