[BUGFIX] Fix animation editor frame outlines being improperly generated for multisparrow characters #6382
Conversation
github-actions
bot
added
status: pending triage
AbnormalPoof
added
type: minor bug
AbnormalPoof
left a comment
AbnormalPoof
left a comment
There was a problem hiding this comment.
One note when reviewing the code
| // Forcefully create a new FlxAtlasFrames collection so that we don't add to the same FlxAtlasFrames instance. | ||
| var texture:Null<FlxAtlasFrames> = null; | ||
|
|
||
| if (frameBase == null) | ||
| { | ||
| frameBase = FlxGraphic.fromAssetKey(Paths.image(_data.assetPath), true, this.characterId, true); | ||
| } | ||
|
|
||
| if (frameBase != null) | ||
| { | ||
| texture = new FlxAtlasFrames(frameBase); | ||
| } |
There was a problem hiding this comment.
These changes don't seem to be used in the Animation Editor at all.
There was a problem hiding this comment.
Using Paths.getSparrowAtlas from multisparrow characters, regardless of where in the code, will retreive the frame collection with appended frames from other spritesheets since Flixel constantly reuses the frame collection objects that have the same base graphic.
While this could be moved directly to the animation editor, I found it somewhat nicer to put in the Multisparrow character class in case other sprites end up using the same base asset path as a multisparrow character, saving the need to have the non-multisparrow character have the same frames as the multisparrow character. For example this change will make Pico opponent not have the same frames as Pico playable and therefore prevent Pico opponent having the same outline problems as Pico playable after Pico playable has been created at least once.
2 participants
Linked Issues
None that I can think of.
Description
The animation editor uses the character's frames to generate the outline data. This works great most of the time, however for multisparrow characters, it can lead to generating the frame outlines for frames that aren't on the main spritesheet, considering the frames get appended to the character's frame collection.
The PR fixes it by forcefully creating a new frame collection instance for multisparrow characters (since Flixel reuses the frame collection instances, even if it has appended frames from other frame collections).
The memory usage shouldn't in theory be horrible, however if you find a better solution, let me know.
Screenshots/Videos
Pico (Playable) Before:
Pico (Playable) After:
