[ENHANCEMENT] Move the Chart Editor Notifications Up a Bit #6445
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Hundrec
added
size: medium
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
#6436
Description
Now the notifications have been moved up! It does this by setting
NotificationManager'sAnimateFromBottomfield to a cutsom version that doesn't use theGUTTER_SIZEvariable.There's probably a better place to put the redefintion of
AnimateFromBottomand might be a bit overboard with an entire redefine, but oh well, it works!Note
For some reason, the first notification to ever pop up is always off by about 10, but that was a thing before this PR.
Screenshots/Videos
Notif-Move-Yea.mp4