Skip to content

[ENHANCEMENT] Move the Chart Editor Notifications Up a Bit #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ENHANCEMENT] Move the Chart Editor Notifications Up a Bit #6445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions source/funkin/ui/debug/charting/handlers/ChartEditorNotificationHandler.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package funkin.ui.debug.charting.handlers;

#if FEATURE_CHART_EDITOR
import haxe.ui.animation.AnimationBuilder;
import haxe.ui.components.Button;
import haxe.ui.containers.HBox;
import haxe.ui.core.Screen;
import haxe.ui.notifications.Notification;
import haxe.ui.notifications.NotificationManager;
import haxe.ui.notifications.NotificationType;
Expand All @@ -15,6 +17,35 @@ class ChartEditorNotificationHandler
// Setup notifications.
@:privateAccess
NotificationManager.GUTTER_SIZE = 45;

NotificationManager.instance.animationFn = AnimateFromBottom;
}

// since GUTTER_SIZE affects both x and y, we'll replace the positioning with this!
// for some reason the first notif always has a downwards offset of like 10 and idk how to fix that
// that was also a problem before this
public static function AnimateFromBottom(notifications:Array<Notification>):Array<AnimationBuilder>
{
var builders = [];

var scy = Screen.instance.height;
var baselineY = scy - 65;

for (notification in notifications)
{
var builder = new AnimationBuilder(notification);
builder.setPosition(0, "top", Std.int(notification.top), true);
builder.setPosition(100, "top", Std.int(baselineY - notification.height), true);
if (notification.opacity == 0)
{
builder.setPosition(0, "opacity", 0, true);
builder.setPosition(100, "opacity", 1, true);
}
builders.push(builder);
baselineY -= (notification.height + @:privateAccess NotificationManager.SPACING);
}

return builders;
}

/**
Expand Down
Loading