Remove the unused user data EsGsLdsSize #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This user data was added to keep some compatibility with old PAL. At that time, PAL expected this user data to handle ES-GS merged shader and NGG correctly on GFX9 and GFX10.1. But LLPC doesn't need this user data at all since we always know ES stage when building the pipeline. And the LDS calculation and allocation of GS stage are applied to full ES-GS pipeline. In this change, the user data EsGsLdsSize is not added to entry-point argument. This SGPR is saved. Also, we don't need to tell PAL with metadata EsGsLdsSize.
Test summary for commit 28014e9CTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
nhaehnle
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This user data was added to keep some compatibility with old PAL. At that time, PAL expected this user data to handle ES-GS merged shader and NGG correctly on GFX9 and GFX10.1. But LLPC doesn't need this user data at all since we always know ES stage when building the pipeline. And the LDS calculation and allocation of GS stage are applied to full ES-GS pipeline.
In this change, the user data EsGsLdsSize is not added to entry-point argument. This SGPR is saved. Also, we don't need to tell PAL with metadata EsGsLdsSize.