Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused user data EsGsLdsSize #2885

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Remove the unused user data EsGsLdsSize #2885

merged 1 commit into from
Dec 20, 2023

Commits on Dec 15, 2023

  1. Remove the unused user data EsGsLdsSize 

    This user data was added to keep some compatibility with old PAL. At
that time, PAL expected this user data to handle ES-GS merged shader and
NGG correctly on GFX9 and GFX10.1. But LLPC doesn't need this user data
at all since we always know ES stage when building the pipeline. And the
LDS calculation and allocation of GS stage are applied to full ES-GS
pipeline.

In this change, the user data EsGsLdsSize is not added to entry-point
argument. This SGPR is saved. Also, we don't need to tell PAL with
metadata EsGsLdsSize.
    @amdrexu
    amdrexu committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    28014e9 View commit details
    Browse the repository at this point in the history