Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new test expects shorter term names #739

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

turbomam
Copy link
Member

@turbomam turbomam commented Jan 2, 2024

@turbomam turbomam linked an issue Jan 2, 2024 that may be closed by this pull request
@turbomam
Copy link
Member Author

turbomam commented Jan 2, 2024

This PR errors out as expected ecause there are two terms with names over 20 characters:

poetry run python -m unittest discover
.INFO:root:Importing linkml:types as /home/runner/.cache/pypoetry/virtualenvs/mixs-VD9cwaNk-py3.10/lib/python3.10/site-packages/linkml_runtime/linkml_model/model/schema/types from source /home/runner/work/mixs/mixs/tests/../src/mixs/schema/mixs.yaml; base_dir=None
F
======================================================================
FAIL: test_term_name_length (tests.test_term_name_length.TestTermNameLength)
Test term name length.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/mixs/mixs/tests/test_term_name_length.py", line 36, in test_term_name_length
    self.assertDictEqual(slot_name_length_too_long, {},
AssertionError: {'nose_mouth_teeth_throat_disord': 30, 'x16s_recover_software': 21} != {}
- {'nose_mouth_teeth_throat_disord': 30, 'x16s_recover_software': 21}
+ {} : Slots whose names are greater than [20](https://github.com/GenomicsStandardsConsortium/mixs/actions/runs/7387536437/job/20096442275#step:7:21) characters: {'nose_mouth_teeth_throat_disord': 30, 'x16s_recover_software': [21](https://github.com/GenomicsStandardsConsortium/mixs/actions/runs/7387536437/job/20096442275#step:7:22)}

----------------------------------------------------------------------
Ran 2 tests in 2.661s

FAILED (failures=1)


make: *** [Makefile:1[22](https://github.com/GenomicsStandardsConsortium/mixs/actions/runs/7387536437/job/20096442275#step:7:23): test-python] Error 1
Error: Process completed with exit code 2.

@turbomam
Copy link
Member Author

turbomam commented Jan 2, 2024

Action item: rename

{'nose_mouth_teeth_throat_disord': 30, 'x16s_recover_software': 21}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python test for term name length
1 participant