Skip to content

Bump bindgen version #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Bump bindgen version #40

merged 2 commits into from
Nov 30, 2024

Conversation

aesteve-rh
Copy link
Contributor

This bump was required as it was causing fix753 workaround to fail.

@Gnurou
Copy link
Owner

Gnurou commented Nov 22, 2024

Hi Albert! This looks fine to me, but just for my curiosity can you explain what the new bindgen version does differently that makes things work?

@aesteve-rh
Copy link
Contributor Author

Checking the changelog, I think the change that is probably making it work is this one: rust-lang/rust-bindgen#2779

From my experiments, it looked like MARK_FIX_753 macro was not being parsed correctly. The fix is for function-like macros, whereas the MARK_FIX_753 macro is a declaration. But it is the only related thing I've seen at first glance, so it is a fair guess.

Either that, or some of the dependencies that have been updated in the crate, for example, clang: rust-lang/rust-bindgen@39232cc

@Gnurou Gnurou merged commit 7009b03 into Gnurou:master Nov 30, 2024
1 check passed
@Gnurou
Copy link
Owner

Gnurou commented Nov 30, 2024

I'm not sure I get it because I never ran into any problem, but in any case this update should be harmless (and the extra rebuild condition is useful). Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants