-
Notifications
You must be signed in to change notification settings - Fork 460
Add getopt in e2e script for enhanced command line arg handling. #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ef9f117
to
993444f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3433 +/- ##
==========================================
+ Coverage 78.82% 79.04% +0.22%
==========================================
Files 139 140 +1
Lines 18440 18520 +80
==========================================
+ Hits 14535 14640 +105
+ Misses 3421 3395 -26
- Partials 484 485 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @Tulsishah, @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
@gemini-code-assist /gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I couldn't finish reviewing it earlier in the day. Couple more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relying on Nitin's review!
Description
Adding
getopt
option in e2e test run script which offers enhanced arg handling and clean way of executing script.Ref: https://www.man7.org/linux/man-pages/man3/getopt.3.html
Fixed optional resource usage collection in e2e script as per the comment in : #3414 (comment)
Example ways to run the script~
Example ways to not run the script~
Link to the issue in case of a bug fix.
b/426462003
Testing details
Any backward incompatible change? If so, please explain.
No